From 09f8ef9be055f44f96c490f7466bd47439c2d344 Mon Sep 17 00:00:00 2001
From: canove <cassio@economicros.com.br>
Date: Mon, 12 Oct 2020 18:43:19 -0300
Subject: [PATCH] chore: removed redundant user check on session controller

---
 backend/src/services/AuthServices/RefreshTokenService.ts | 4 ----
 backend/src/services/UserServices/ShowUserService.ts     | 4 +---
 2 files changed, 1 insertion(+), 7 deletions(-)

diff --git a/backend/src/services/AuthServices/RefreshTokenService.ts b/backend/src/services/AuthServices/RefreshTokenService.ts
index 8b96cfe..2147926 100644
--- a/backend/src/services/AuthServices/RefreshTokenService.ts
+++ b/backend/src/services/AuthServices/RefreshTokenService.ts
@@ -30,10 +30,6 @@ export const RefreshTokenService = async (token: string): Promise<Response> => {
 
   const user = await ShowUserService(id);
 
-  if (!user) {
-    throw new AppError("No user found with this ID.", 401);
-  }
-
   if (user.tokenVersion !== tokenVersion) {
     throw new AppError("Session revoked. Please login.", 401);
   }
diff --git a/backend/src/services/UserServices/ShowUserService.ts b/backend/src/services/UserServices/ShowUserService.ts
index 63d50cc..dcd298d 100644
--- a/backend/src/services/UserServices/ShowUserService.ts
+++ b/backend/src/services/UserServices/ShowUserService.ts
@@ -1,9 +1,7 @@
 import User from "../../models/User";
 import AppError from "../../errors/AppError";
 
-const ShowUserService = async (
-  id: string | number
-): Promise<User | undefined> => {
+const ShowUserService = async (id: string | number): Promise<User> => {
   const user = await User.findByPk(id, {
     attributes: ["name", "id", "email", "profile", "tokenVersion"]
   });