From 1780436b939b76814e689a2f4efc8aa68f8cefd4 Mon Sep 17 00:00:00 2001 From: kurob1993 Date: Mon, 6 Apr 2020 10:04:03 +0700 Subject: [PATCH] fix: make pupBrowser and pupPage available sooner (#137) * move this.pupBrowser variable to line 51 to resolve not being able to close the browser when it is not connected to the internet * move pupPage along with pupBrowser Co-authored-by: Pedro S. Lopez --- src/Client.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Client.js b/src/Client.js index e1e2255..b688a35 100644 --- a/src/Client.js +++ b/src/Client.js @@ -48,6 +48,9 @@ class Client extends EventEmitter { const page = (await browser.pages())[0]; page.setUserAgent(UserAgent); + this.pupBrowser = browser; + this.pupPage = page; + if (this.options.session) { await page.evaluateOnNewDocument( session => { @@ -303,9 +306,6 @@ class Client extends EventEmitter { window.Store.AppState.on('change:state', (_AppState, state) => { window.onAppStateChangedEvent(state); }); }); - this.pupBrowser = browser; - this.pupPage = page; - /** * Emitted when the client has initialized and is ready to receive messages. * @event Client#ready